Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 2.7 #212

Merged
merged 8 commits into from
Jan 4, 2020
Merged

Drop python 2.7 #212

merged 8 commits into from
Jan 4, 2020

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Jan 2, 2020

Fixes #83

There are a lot of places where galgebra can benefit from the keyword-only argument syntax.

If desired, I can split the last commit of this PR to a new PR.

@eric-wieser eric-wieser added this to the 0.5.0 milestone Jan 2, 2020
@codecov
Copy link

codecov bot commented Jan 2, 2020

Codecov Report

Merging #212 into master will decrease coverage by 0.53%.
The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
- Coverage   70.77%   70.24%   -0.54%     
==========================================
  Files           9        9              
  Lines        4592     4533      -59     
==========================================
- Hits         3250     3184      -66     
- Misses       1342     1349       +7
Impacted Files Coverage Δ
galgebra/__init__.py 100% <ø> (ø) ⬆️
galgebra/printer.py 77.3% <100%> (+0.01%) ⬆️
galgebra/deprecated.py 98.5% <100%> (-0.03%) ⬇️
galgebra/mv.py 72.41% <100%> (-0.45%) ⬇️
galgebra/ga.py 74.01% <100%> (-0.23%) ⬇️
galgebra/metric.py 71.46% <100%> (-2.47%) ⬇️
galgebra/utils.py 65.51% <66.66%> (-6.36%) ⬇️
galgebra/lt.py 43% <80%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd43141...33ddee7. Read the comment docs.

@eric-wieser eric-wieser requested a review from utensil January 2, 2020 17:05
@eric-wieser eric-wieser force-pushed the drop-python-2.7 branch 2 times, most recently from 9bc7864 to c9a9f0c Compare January 2, 2020 17:15
@pygae pygae deleted a comment from lgtm-com bot Jan 2, 2020
@pygae pygae deleted a comment from lgtm-com bot Jan 2, 2020
@eric-wieser eric-wieser force-pushed the drop-python-2.7 branch 2 times, most recently from d96d65c to e87bc40 Compare January 2, 2020 17:24
@eric-wieser
Copy link
Member Author

@thecodebeat, any idea what's going on with the reported fixed issue count here?

@pygae pygae deleted a comment from lgtm-com bot Jan 2, 2020
@@ -9,12 +9,8 @@
PY2 = sys.version_info[0] == 2
PY3 = sys.version_info[0] == 3
Copy link
Contributor

@waldyrious waldyrious Jan 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these two lines (and import sys above) also should be removed — or am I missing something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module is public API, so needs to stick around probably for another release. Imagine a project that works in both 2 and 3, and depends on galgebra.utils. Such a project should keep working in 3 after this change, even though utils isn't doing anything useful any more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could actually drop utils in entirety in a later PR since I'm pretty sure no one would have been using in any serious way after I introduced it.

@utensil utensil merged commit a8466cf into pygae:master Jan 4, 2020
@eric-wieser eric-wieser deleted the drop-python-2.7 branch April 20, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Python 2.7
3 participants